feat: Allow put_metric_data to be sent gzipped #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it isn't possible to wait for set_global_recorder to be called before proceeding, making it possible to drop metrics that are sent between the call to `init` and `set_global_recorder` being called. By separating the driver task like this one can call init first, waiting to send and metrics until it is done, and then spawn the future on a tokio task.
No movement on awslabs/aws-sdk-rust#1068 for almost a year now so I think we need to just hack it in our selves
|
@john-eriksson-imperva Resurrecting #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No movement on awslabs/aws-sdk-rust#1068 for almost a year now so I think we need to just hack it in our selves
Based on #57